Skip to content

[next] fix(docs): bring back NcAppSidebar in docs #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raimund-schluessler merged 1 commit into from
Jan 30, 2024
Merged

[next] fix(docs): bring back NcAppSidebar in docs #5167

raimund-schluessler merged 1 commit into from
Jan 30, 2024

Conversation

@raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Jan 29, 2024 •
edited
Loading

☑️ Resolves

  • This brings back the NcAppSidebar example in the docs and adjusts the style to actually show NcContent.
  • It also fixes an issue in the styleguide with Teleport as the #skip-actions element was not present.

@raimund-schluessler raimund-schluessler added this to the 9.0.0-alpha.1 milestone Jan 29, 2024
@raimund-schluessler raimund-schluessler added bug Something isn't working 2. developing Work in progress vue 3 feature: documentation Related to the documentation labels Jan 29, 2024
@raimund-schluessler raimund-schluessler changed the title fix(docs): bring back NcAppSidebar in docs [next] fix(docs): bring back NcAppSidebar in docs Jan 29, 2024
@susnux
Copy link
Contributor

susnux commented Jan 29, 2024

Adjust the styleguide to have a <div id="#skip-actions"> element somewhere (preferred, but I don't know how).

I have not looked into it, but maybe just add this to the examples that use NcContent?
Otherwise maybe (dirty!) inject it using global.requires.js.

@raimund-schluessler raimund-schluessler force-pushed the fix/noid/styleguide-teleport branch from fe0519a to 0710c9a Compare January 29, 2024 12:50
@raimund-schluessler
Copy link
Contributor Author

raimund-schluessler commented Jan 29, 2024 •
edited
Loading

Adjust the styleguide to have a <div id="#skip-actions"> element somewhere (preferred, but I don't know how).

I have not looked into it, but maybe just add this to the examples that use NcContent? Otherwise maybe (dirty!) inject it using global.requires.js.

That is a great idea, thanks! I added an element and it makes the styleguide work. The skip actions is even functional. 👍

@raimund-schluessler raimund-schluessler marked this pull request as ready for review January 29, 2024 12:51
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 29, 2024
susnux
susnux approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works but styles are broken (like before)

@raimund-schluessler
Copy link
Contributor Author

raimund-schluessler commented Jan 29, 2024

Could we merge this and release 9.0.0-alpha.1? Then I could proceed and merge the Tasks vue 3 migration nextcloud/tasks#1971 as well.

@raimund-schluessler raimund-schluessler merged commit 73eb961 into next Jan 30, 2024
@raimund-schluessler raimund-schluessler deleted the fix/noid/styleguide-teleport branch January 30, 2024 08:35
@Antreesy Antreesy mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working feature: documentation Related to the documentation

Projects

None yet

Milestone

9.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

4 participants

@raimund-schluessler @susnux @ShGKme